This repository was archived by the owner on Apr 21, 2022. It is now read-only.
Add type definition for typescript#71
Merged
vilyapilya merged 3 commits intologdna:masterfrom Jan 15, 2020
Merged
Conversation
tjoskar
commented
Sep 5, 2019
renarsvilnis
suggested changes
Oct 4, 2019
tjoskar
force-pushed
the
feat/typescript-types
branch
from
5fef675 to
11b26f0
Compare
Contributor
Author
|
Thanks @renarsvilnis and great points! |
|
Super excited for this PR. Is this likely to make it through? Any way to help? Thanks! |
vilyapilya
reviewed
Jan 10, 2020
added 2 commits
January 11, 2020 13:25
After review comment from @vilyapilya
vilyapilya
approved these changes
Jan 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added typescript types, as discussed here: #68
Questions:
tagsis mention under setup but it is not documented? But I guess it should be included in the types?What level does logdna support? According to the docs
YourCustomLevelis supported so I guess any string is a valid level? But when I look at this line 8 different levels are supported? But only 6 of them are listed in the config. What should the type oflevelbe?cleanUpSIGTERMandcleanUpSIGINTare listed in the docs but not in the code(?) should it be removed from the README file?