This repository was archived by the owner on Apr 21, 2022. It is now read-only.
Fix the tests so they don't fail with the recent updates#82
Merged
Conversation
smusali
suggested changes
Nov 8, 2019
Contributor
smusali
left a comment
smusali
left a comment
There was a problem hiding this comment.
@vilyapilya, please, make sure it passes the linting check
smusali
changed the title
`flushAll` callback was called too early
Fix typo
vilyapilya
force-pushed
the
fixFlushAllCallback
branch
from
900f2d4 to
b1fe4be
Compare
smusali
suggested changes
Nov 12, 2019
| const errors = []; | ||
| loggers.forEach((logger) => { | ||
| logger._flush((err) => { | ||
| if (err) { |
Contributor
There was a problem hiding this comment.
use error for readability since the array is errors - basically, adding error into errors: the list of errors
Contributor
Author
There was a problem hiding this comment.
I don't think it makes a difference.
weizou19
approved these changes
Nov 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#76 - changes are good but they break the current tests.
The tests fail bc the code continues to execute after done is called in aftereach block. The initial intention of the block was to clean the logger after each test. I removed afterEach part. It is not needed anymore since each test creates its own logger.