This repository was archived by the owner on Apr 21, 2022. It is now read-only.
Only set user-agent header in Node#87
Merged
vilyapilya merged 1 commit intologdna:masterfrom Dec 4, 2019
Merged
Conversation
smusali
requested review from
andkon,
dchai76,
smusali,
vilyapilya and
weizou19
vilyapilya
approved these changes
Dec 4, 2019
Contributor
|
Thank you @mvasigh for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #86
This avoids setting the
user-agentheader altogether, which should be ok per spec but currently emits a logged error in Safari and Chrome (see issue) so the fix avoids setting the header altogether in the browser since that is a large chunk of the browser market share, thoughts on this?