Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use expanduser to get home path - fix for windows #115

Merged
merged 1 commit into from May 9, 2018

Conversation

@kevinegami
Copy link
Contributor

@kevinegami kevinegami commented May 9, 2018

os.environ['HOME'] does not work on windows, os.path.expanduser("~") will work cross platform

@kevinegami kevinegami mentioned this pull request May 9, 2018
@dmr-loggly
Copy link

@dmr-loggly dmr-loggly commented May 9, 2018

Is there an associated bug ticket for this?

@kevinegami
Copy link
Contributor Author

@kevinegami kevinegami commented May 9, 2018

No JIRA. It was found when implementing Jira Ticket: loggly-17274 PR here: #114

@kevinegami kevinegami merged commit 9c1e891 into loggly:master May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.