fix(web): keep the About mureo tab pinned as the last dashboard nav item#233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #229: keep the "About mureo" tab pinned as the last dashboard nav item, even when web-extension plugins (e.g. the agency extension) register their own tabs.
Previously the static nav order was setup/demo/byod/about/danger and extension tabs were appended at the end of the nav list, so any installed plugin tab landed below About.
Changes
mureo/_data/web/app.html: static nav order is now setup / demo / byod / danger / about.mureo/_data/web/extensions.js:_renderNavIteminserts extension tabs before the About item (nav.insertBefore(li, aboutItem)viaclosest("li")on the[data-dashboard-nav="about"]anchor), falling back to the previousappendChildwhen the About item is absent. Extension tabs therefore slot between Danger Zone and About, however many plugins register one.tests/test_web_about.py: two new static pins — the lastdata-dashboard-navkey inapp.htmlisabout, andextensions.jscarries the about-anchoredinsertBeforewiring.No nav-order-dependent code exists elsewhere (verified: no
:last-child/nextSibling/index-based selectors target the dashboard nav;BUILTIN_TABSandDEFAULT_NAVare position-independent). DOM order now matches visual order, so keyboard Tab reaches About last as well.Test plan
tests/test_web_about.py— 17 pass (incl. the two new order pins, TDD red→green)