fix(adapters): add ja translations to built-in Google/Meta account credential field labels (#237) - #238
Merged
Merged
Conversation
…edential field labels (#237)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the Japanese configure UI, the built-in Google Ads / Meta Ads per-account field labels stayed English ("Customer ID", "Login Customer ID (MCC)", "Ad Account ID") while plugin-declared fields localize. The built-in
AccountCredentialFielddeclarations simply never used the #186 i18n hooks.Changes
Adds
display_name_i18n/description_i18n{"ja": ...}maps to the three built-in declarations, exactly per the issue's table:customer_idlogin_customer_idaccount_idJapanese descriptions are faithful translations of the English hints (review-verified: the
login_customer_idsemantics — MCC header use, blank-inherits-default, parent_id auto-population — carry over without drift). No consumer changes: the locale-resolved discovery path (i18n[locale] → i18n["en"] → display_name) already picks these up, andenkeeps resolving to the baredisplay_name.Test plan
tests/adapters/google_ads/test_adapter.py/tests/adapters/meta_ads/test_adapter.py— new pins for the exact ja labels, unchanged en fallback, non-empty ja descriptions (non-empty matters: the resolver treats""as undeclared)Closes #237