ci: allow fork checkout in submission validator - #116
Closed
duongja wants to merge 1 commit into
Closed
Conversation
|
|
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the
Validate Submissionworkflow for fork-based solution PRs.Current failure on LP-0002 submission PR #115:
Validate SubmissionCheckout PR head (untrusted data, never executed)Refusing to check out fork pull request code from a pull_request_target workflowThe workflow already treats the PR-head checkout as untrusted data and does not execute code from it. It checks out the fork only so the trusted base-branch validation script can inspect submitted markdown content and changed files.
Change:
allow-unsafe-pr-checkout: trueon the PR-headactions/checkout@v4step.After this merges, fork-based solution PRs such as #115 can be rerun by the normal validator workflow.