Skip to content

Enhance / shortcuts#10290

Merged
tiensonqin merged 5 commits intomasterfrom
enhance/shortcuts-x
Oct 13, 2023
Merged

Enhance / shortcuts#10290
tiensonqin merged 5 commits intomasterfrom
enhance/shortcuts-x

Conversation

@xyhp915
Copy link
Copy Markdown
Collaborator

@xyhp915 xyhp915 commented Sep 27, 2023

@github-actions github-actions bot added the :type/enhancement Enhancement to product. Does not affect the overall basic use. label Sep 27, 2023
@xyhp915 xyhp915 changed the title WIP: Enhance / shortcuts Enhance / shortcuts Oct 9, 2023
@xyhp915 xyhp915 requested review from andelf and tiensonqin October 9, 2023 13:58
Copy link
Copy Markdown
Collaborator

@andelf andelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not editable if a shortcut is disabled.

After clicking "Disabled":
image

image

@xyhp915 xyhp915 requested a review from andelf October 12, 2023 04:56
@xyhp915
Copy link
Copy Markdown
Collaborator Author

xyhp915 commented Oct 12, 2023

Still not editable if a shortcut is disabled.

After clicking "Disabled": image

image

Fixed.

Copy link
Copy Markdown
Collaborator

@andelf andelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified. LGTM

@tiensonqin tiensonqin merged commit 9ca6e78 into master Oct 13, 2023
@tiensonqin tiensonqin deleted the enhance/shortcuts-x branch October 13, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:type/enhancement Enhancement to product. Does not affect the overall basic use.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disabled shortcut cannot be edited via keymap editor // Re-index shortcut is disabled

3 participants