Skip to content

fix: add Task tag when setting status#12719

Merged
RCmerci merged 2 commits into
masterfrom
fix/task-tag-status-767
May 25, 2026
Merged

fix: add Task tag when setting status#12719
RCmerci merged 2 commits into
masterfrom
fix/task-tag-status-767

Conversation

@RCmerci
Copy link
Copy Markdown
Contributor

@RCmerci RCmerci commented May 25, 2026

Summary

  • add :logseq.class/Task when setting task properties on tagged blocks whose classes do not provide that property
  • keep class objects that define status from being forced into Task
  • update AgentBridge listener tests to allow start reaction/status side effects

Tests

  • bb dev:lint-and-test
  • bb dev:cli-e2e
  • bb dev:cli-e2e-sync --skip-build

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts how task-related properties (status/scheduled/deadline) implicitly add the :logseq.class/Task tag, ensuring tagged blocks become Tasks when their tag/classes don’t provide the property, while avoiding forcing blocks into Task when their class already defines the property. It also updates CLI AgentBridge tests to accommodate new reaction/status side effects that invoke DB-worker operations.

Changes:

  • Add class-property-aware logic to decide when setting status/scheduled/deadline should also add the :logseq.class/Task tag.
  • Expand outliner property tests to cover tagged blocks whose classes do not provide status, and blocks whose classes do provide it.
  • Update AgentBridge listener tests to stub additional transport/invoke methods used by start-reaction/status side effects.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/test/logseq/cli/command/agent_test.cljs Extends DB-worker transport stubs in AgentBridge tests to allow reaction/status side effects (:thread-api/q, :thread-api/apply-outliner-ops).
deps/outliner/test/logseq/outliner/property_test.cljs Adds coverage for status setting on tagged blocks with classes that do/do-not define status, validating Task tag behavior.
deps/outliner/src/logseq/outliner/property.cljs Refactors Task-tagging condition into helper fns and adds a class-property check to decide when to apply :logseq.class/Task.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@RCmerci RCmerci merged commit 860904b into master May 25, 2026
15 checks passed
@0ldcamel502
Copy link
Copy Markdown

I have just tested on iPhone, it seems the issue hasn’t been resolved.

Uploading ScreenRecording_05-26-2026 06-36-26_1.mov…

@0ldcamel502
Copy link
Copy Markdown

ScreenRecording_05-26-2026.06-36-26_1.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants