fix: sync code editor content on prop changes - #12885
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a UI sync bug where CodeMirror-backed code blocks (notably calc) didn’t update their displayed editor text when the code prop changed (e.g., same block open in page + sidebar), even though derived calc results could update.
Changes:
- Add a small
sync-editor-code!helper to push updatedcodeprop into the existing CodeMirror instance when it’s not focused. - Avoid eagerly evaluating calc lines for non-calc blocks by deriving
calc?once and lazily initializing calc state. - Simplify repeated
"calc"checks by introducingcalc-mode?and reusingcalc?in render + effects.
Verification notes:
- Static review only (no runtime UI/REPL validation executed in this environment). Change aligns with reported reproduction in logseq/db-test#990 (sidebar editor content staying stale while results update).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tiensonqin
force-pushed
the
fix/code-sidebar-sync
branch
from
July 15, 2026 14:09
69c0d37 to
d4aad32
Compare
tiensonqin
approved these changes
Jul 15, 2026
tiensonqin
force-pushed
the
fix/code-sidebar-sync
branch
from
July 15, 2026 14:36
d4aad32 to
173695d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix logseq/db-test#990