refactor(rn): bump expo SDK to 57 - #69
Merged
Merged
Conversation
simeng-li
requested review from
a team,
charIeszhao and
wangsijie
and removed request for
a team
August 31, 2026 07:37
simeng-li
enabled auto-merge (squash)
September 10, 2026 08:47
charIeszhao
reviewed
Sep 10, 2026
charIeszhao
approved these changes
Sep 10, 2026
Widen the expo-crypto / expo-secure-store / expo-web-browser peer caps to <58. On npm the old <57 cap is a hard ERESOLVE install failure for every Expo SDK 57 project, not just a peer warning. Bump the dev deps and the sample app to Expo SDK 57 (expo 57.0.21, RN 0.86.3, React 19.2.3). react-native is pinned exactly, matching Expo's own template, so it cannot drift ahead of the react-native patch that the installed expo's bundledNativeModules validates against.
simeng-li
force-pushed
the
simeng-refactor-bump-expo-sdk-to-57
branch
from
September 10, 2026 08:59
ab7a7db to
6279dfb
Compare
simeng-li
disabled auto-merge
September 10, 2026 09:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes logto-io/logto#9578.
@logto/rn@1.2.0caps theexpo-crypto/expo-secure-store/expo-web-browserpeer ranges at<57. On npm this is a hardERESOLVEinstall failure for every Expo SDK 57 project —npm i @logto/rnfails outright, nothing is installed. (pnpm degrades to a peer warning instead, which is why this looked milder than it is.)Widen the caps to
<58and move the dev deps and the sample app onto Expo SDK 57, so the widened range is actually exercised.No source changes — the SDK code is unaffected by the Expo 57 bump. The published
build/output of all three Expo modules is byte-identical between 56.x and 57.x,.d.tsincluded; only native code and package metadata changed.packages/rn/package.json: peer caps<57→<58; dev deps toexpo-*@57andreact-native@^0.86.3; version1.2.0→1.3.0.packages/rn-sample/package.json: Expo SDK 56 → 57 (expo~57.0.21,@expo/metro-runtime~57.0.15,expo-status-bar,expo-crypto,expo-secure-store^57.0.3,expo-web-browser,react/react-dom19.2.3,react-native0.86.3), matching Expo 57.0.21'sbundledNativeModules.react-nativeis pinned exactly rather than with~, matching Expo's own template. A tilde range lets RN float to a newer patch than the resolvedexpoexpects, which is what caused the earlier 57.0.16 / 0.86.3 mismatch.Testing
Tested locally
pnpm -r build && pnpm -r lint && pnpm -r test— green, 5/5 tests passing.expo@57.0.21'sbundledNativeModules.json(the fileexpo-doctorreads) — all aligned.ERESOLVEagainst1.2.0, then confirmed a packed1.3.0resolves clean in an Expo SDK 57 npm project.Checklist
.changeset