chore: Provide IBM Plex Sans to fix story app lag to nix - #2592
Merged
Conversation
Contributor
Author
|
(Human) I've tested the PR. Before PR, scrolling in the gallary application ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
GPUI resolves the Linux system UI font to IBM Plex Sans. On NixOS, that font was not available inside the development shell, so text rendering repeatedly took the missing-font fallback path. With
RUST_BACKTRACE=1enabled by the shell, those fallback errors also captured backtraces and caused high single-thread CPU usage during scrolling and other UI interactions.Providing the expected font removes that hot path. In an 8-second runtime sample, CPU time dropped from approximately 4.05 seconds to 0.97 seconds, and profiling no longer showed unwind/backtrace work.
Testing
nix flake check --no-buildnix develop --command cargo run --releasefc-match "IBM Plex Sans"resolves toIBMPlexSans-Regular.otfinside the dev shellnix build .#defaultPackage.x86_64-linuxRelated issue: #1621