Skip to content

editor: Reveal search match after manual scroll - #2955

Merged
huacnlee merged 3 commits into
longbridge:mainfrom
hlcfan:fix-search-after-manual-scroll
Sep 5, 2026
Merged

editor: Reveal search match after manual scroll#2955
huacnlee merged 3 commits into
longbridge:mainfrom
hlcfan:fix-search-after-manual-scroll

Conversation

@hlcfan

@hlcfan hlcfan commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Description

Fix Next/Previous advancing the search counter without revealing the match after manual scrolling. Search navigation now scrolls in either direction while preserving configured surrounding-line padding; cursor navigation keeps its existing direction restrictions.

Screenshot

Before

Before.mov

After

After.mov

Validation

  • Added regression tests for Next scrolling upward and Previous scrolling downward, including surrounding-line padding.
  • cargo test -p gpui-base input:: --lib --offline — 152 tests passed locally.

AI assistance: Codex generated the implementation and regression tests.

Checklist

  • I have read the CONTRIBUTING document and followed the guidelines.
  • Reviewed the changes in this PR and confirmed AI generated code (If any) is accurate.
  • Passed cargo run for story tests related to the changes.
  • Tested macOS, Windows and Linux platforms performance (if the change is platform-specific) — Not applicable; the search navigation fix is platform-independent.

@hlcfan hlcfan closed this Sep 4, 2026
@hlcfan hlcfan reopened this Sep 5, 2026
@huacnlee
huacnlee merged commit e9a313d into longbridge:main Sep 5, 2026
10 of 18 checks passed
@hlcfan
hlcfan deleted the fix-search-after-manual-scroll branch September 5, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants