base: move the native examples into their own package - #2963
Merged
Conversation
gpui-base declared gpui_platform for every non-wasm target although only the examples use it, which fails the build on targets that supply their own gpui::Platform (iOS, Android). Give the native showcase and motion examples a package of their own, like examples/wasm already has, so the library manifest no longer mentions gpui_platform. Closes longbridge#2962.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gpui-basedeclaresgpui_platformfor every non-wasm target, but only the examples use it. For targets that supply their own backend throughApplication::with_platform(iOS, Android), the build fails insidegpui_platform.Following what
examples/wasmalready does, this moves the native showcase and motion examples into their own package,gpui-base-examples, which includes the same shared code with#[path]; thegpui-basemanifest no longer mentionsgpui_platform.src/bin/components.rsandexamples/components.rswere two entry points to the same showcase and become the package'scomponentsbin; the README commands are updated accordingly.Verified:
cargo check -p gpui-base-examples --binscargo check -p gpui-base --examples --tests --benchescargo check -p gpui-base --target aarch64-apple-ios-simand--target wasm32-unknown-unknowncargo check --workspacecargo fmt --all --checkCloses #2962