website: Remove two Vue components orphaned by the Astro migration - #2965
Merged
Conversation
`GitHubStar.vue` and `SidebarFilter.vue` have had no references since the VitePress to Astro migration in #2926. `Nav.astro` renders the GitHub star link inline, and no page mounts a sidebar filter. The remaining Vue components are all mounted by pages and stay as they are; Astro supports Vue islands through the official `@astrojs/vue` integration. Identified and removed with AI assistance. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RwSD6p7jLbJEF8hYtrhth4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
website/src/components/GitHubStar.vueandwebsite/src/components/SidebarFilter.vuehave had no references since the VitePress to Astro migration in #2926.Nav.astrorenders the GitHub star link with inline markup, and no page or component mounts a sidebar filter, so both files were dead source.The other seven
.vuefiles underwebsite/src/components/are each mounted by a page and are left untouched. Astro supports Vue islands through the official@astrojs/vueintegration, which the migration adopted deliberately, so their presence is not a leftover.Removing
SidebarFilter.vuerecords the current state rather than changing it: the sidebar filter was already absent from the rendered site, and documentation search is served by Pagefind throughDocSearch.astro. Restoring a sidebar filter would be a separate feature change.Identified and removed with AI assistance.
How to Test
From
website/:grep -rn "GitHubStar\|SidebarFilter" src tests astro.config.mjs package.json bun run buildThe grep should return nothing. The build should complete with 305 pages. The site's appearance and behavior are unchanged, since neither file was reachable.
Checklist
No documentation, locale, or public API changes. Rust tests are not applicable to this website-only change.
🤖 Generated with Claude Code
https://claude.ai/code/session_01RwSD6p7jLbJEF8hYtrhth4