Skip to content

TotalCompactions() returns max not sum — name is misleading #12

Description

@rajfirke

Description

TotalCompactions() takes the maximum compaction count across iterations. If compactions is a running counter, max is correct but the name is misleading. If per-iteration, the result is wrong.

Fix

Rename to MaxCompactions() or document the semantics.

Location

internal/trace/metrics.go:47-54

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomers

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions