Add connectorCapabilities global object#24
Merged
superkhau merged 1 commit intoloopbackio:masterfrom Oct 12, 2016
duffn:connector-capabilities
Merged
Add connectorCapabilities global object#24superkhau merged 1 commit intoloopbackio:masterfrom duffn:connector-capabilities
superkhau merged 1 commit intoloopbackio:masterfrom
duffn:connector-capabilities
Conversation
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
|
Can one of the admins verify this patch? |
superkhau
approved these changes
Oct 12, 2016
superkhau
pushed a commit
that referenced
this pull request
Oct 12, 2016
superkhau
added a commit
that referenced
this pull request
Oct 12, 2016
qpresley
pushed a commit
that referenced
this pull request
Nov 2, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR is to support the new
connectorCapabilitiesobject added to loopback-datasource-juggler as discussed here: loopbackio/loopback-datasource-juggler#1091.This object will allow connectors to tell the tests in basic-querying.test.js whether or not they support a certain operator, so new operators added do not cause downstream connector tests to fail. Tests run when the operator is supported and do not run when it is not.
Example
In a connector's
test/init.jsIn loopback-datasource-juggler
test/basic-querying.test.js