Conversation
Collaborator
Author
|
@Amir-61 @loay @superkhau PTAL |
superkhau
approved these changes
Nov 2, 2016
superkhau
approved these changes
Nov 2, 2016
| } else { | ||
| ds.connector.connect(cb); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
You may consider "console.warn('ibm connectors natively support lazy connect via ... see link")"
Contributor
|
@qpresley I think you need to remove these tests as well: https://github.com/strongloop/loopback-connector-db2/blob/3d286b74713b57f4b438e0c53391b30615a4832c/test/db2.connection.test.js#L75-L117 |
Contributor
Collaborator
Author
|
Yeah, will be doing so later today |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lazy connect does not hold meaning in the IBM Database connectors. On initialization there is no connection acquired for the connector. If the user specifies a min or max connection pool size in the settings past in on initialization then the underlying connection pool in the node-ibm_db module will have connections ready.