Make the autoupdate logic much more generic#48
Merged
Conversation
added 2 commits
April 6, 2017 09:52
jannyHou
reviewed
Apr 6, 2017
| // Now that the column altering statments have been added we can add in the | ||
| // indexes again. | ||
| // ------------------------------------------------------------------------ | ||
| sql = sql.concat(self.buildIndexes(model)); |
Contributor
There was a problem hiding this comment.
function buildIndexes is missing.
Contributor
|
@slnode test please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The autoupdate logic was initially built for DB2 only and relied on system catalogs that do not apply to all databases in the IBM set. These changes will make the autoupdate function much more generic and possibly more functionally correct as it ensures the order of operations will not cause issues such as a column of a table being dropped while an index using that column still exists in the database.
While this may not be the most performant version of autoupdate, this is unlikely to be something users do frequently and the rebuilding of the indexes may improve database performance in some cases.