Skip to content

Remove connection string logging#50

Merged
qpresley merged 1 commit intomasterfrom
connectionStrings
Apr 11, 2017
Merged

Remove connection string logging#50
qpresley merged 1 commit intomasterfrom
connectionStrings

Conversation

@qpresley
Copy link
Copy Markdown
Collaborator

@qpresley qpresley commented Apr 11, 2017

Remove debug logging of connection string details.

When a user has debug set for the connector the full connection string would be printed in the debug output. This runs the risk of exposing login details for the database server and should printed even in the event debugging is enabled. Note that be default debug is not enabled and users have to explicitly enable it for this printing to occur.

jannyHou
jannyHou approved these changes Apr 11, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@jannyHou jannyHou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qpresley qpresley merged commit a9060c6 into master Apr 11, 2017
@qpresley qpresley deleted the connectionStrings branch April 11, 2017 16:13
kjdelisle pushed a commit that referenced this pull request Jul 12, 2017
2.2.1
6e82322 
 * add test case for fromColumnValue (Diana Lau)
 * fix fromColumnValue when val is undefined (Diana Lau)
 * Remove connection string logging (#50) (Quentin Presley)
 * Make the autoupdate logic much more generic (#48) (Quentin Presley)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@jannyHou jannyHou jannyHou approved these changes

@b-admike b-admike b-admike approved these changes

@ssh24 ssh24 ssh24 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@qpresley @jannyHou @b-admike @ssh24