feat: support authentication for rest-crud based APIs #10546
+109
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaqilniz
force-pushed
the
feat/auth-for-rest-crud
branch
2 times, most recently
from
e6c50b5 to
dda4097
Compare
aaqilniz
force-pushed
the
feat/auth-for-rest-crud
branch
3 times, most recently
from
3b6df50 to
f5f7536
Compare
|
can you please try to run again or to test again so it will be available for merging ? |
|
Hello @nabdelgadir , @raymondfeng , what is needed to be able to merge this feature ? It is really important. |
aaqilniz
force-pushed
the
feat/auth-for-rest-crud
branch
from
0e85c89 to
effdaa7
Compare
Contributor
Author
|
Hi, @danysz. I am working on the tests for the changes. I will update the PR soon. |
aaqilniz
force-pushed
the
feat/auth-for-rest-crud
branch
3 times, most recently
from
fbeedf8 to
f73acd6
Compare
Signed-off-by: Muhammad Aaqil <aaqilcs102@gmail.com>
aaqilniz
force-pushed
the
feat/auth-for-rest-crud
branch
from
a94a67f to
7578677
Compare
Contributor
Author
|
Hi, @samarpanB. Can you help me with the tests? The tests should fail as I have added an authentication decorator but it does not take any effect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no way to apply authentication to rest-crud based APIs generated with lb4 rest-crud. This PR provides an idea and a basic implementation for achieving that.
Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈