feat: reject relation generation when same relation name and foreign key#11504
Open
aaqilniz wants to merge 1 commit intoloopbackio:masterfrom
Open
feat: reject relation generation when same relation name and foreign key#11504aaqilniz wants to merge 1 commit intoloopbackio:masterfrom
aaqilniz wants to merge 1 commit intoloopbackio:masterfrom
Conversation
Signed-off-by: Muhammad Aaqil <aaqilcs102@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The relation generator generates relations when a foreign key name is the same as the relation name. But this fails while invoking the APIs.
This PR intercepts the relation generation and rejects it with an error when relation name is the same as the foreign key name.
Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈