feat(cli): Cleanup REST application tooling

[shimks]

• connected to [CLI] Create empty REST API project #723

[shimks]

@slnode test please

[raymondfeng]

No need to change the formatting for this file. Please revert.

[raymondfeng]

No need to change the formatting for this file. Please revert.

If you have a build script to do auto-formatting, please exclude template files.

[shimks]

@raymondfeng With the previous formatting, the indenting on the generated package.json was inconsistent. The indenting is consistent with the new format.

[raymondfeng]

No need to change the formatting for this file. Please revert.

[raymondfeng]

No need to change the formatting for this file. Please revert.

[raymondfeng]

Maybe it's better to remove redundant call of this._setupGenerator() in subclasses instead.

[b-admike]

I suggest rephrasing to contains config for datasources used by this app.

[b-admike]

[virkt25]

We can't extend a Sequence because of DI ... we can't inject new sequence actions if we do this. Below is a sample implementation from log-extension I would suggest using (removing the logging stuff).

    class LogSequence implements SequenceHandler {
      constructor(
        @inject(RestBindings.Http.CONTEXT) public ctx: Context,
        @inject(SequenceActions.FIND_ROUTE) protected findRoute: FindRoute,
        @inject(SequenceActions.PARSE_PARAMS)
        protected parseParams: ParseParams,
        @inject(SequenceActions.INVOKE_METHOD) protected invoke: InvokeMethod,
        @inject(SequenceActions.SEND) protected send: Send,
        @inject(SequenceActions.REJECT) protected reject: Reject,
        @inject(EXAMPLE_LOG_BINDINGS.LOG_ACTION) protected logger: LogFn,
      ) { }

      async handle(req: ParsedRequest, res: ServerResponse) {
        // tslint:disable-next-line:no-any
        let args: any = [];
        // tslint:disable-next-line:no-any
        let result: any;

        try {
          const route = this.findRoute(req);
          args = await this.parseParams(req, route);
          result = await this.invoke(route, args);
          this.send(res, result);
        } catch (err) {
          this.reject(res, req, err);
          result = err;
        }

        await this.logger(req, args, result);
      }
    }

[raymondfeng]

@virkt25 Are you saying @inject doesn't allow inheritance from base classes?

[virkt25]

Yes. I get the following error message

Uncaught Error: Cannot resolve injected arguments for function MySequence: The arguments[0] is not decorated for dependency injection, but a value is not supplied

When I try using the following MySequence (in log-extension acceptance test) ... when I'm trying to inject a custom sequence action.

class MySequence extends DefaultSequence {
      constructor(
        public ctx: Context,
        protected findRoute: FindRoute,
        protected parseParams: ParseParams,
        protected invoke: InvokeMethod,
        public send: Send,
        public reject: Reject,
        @inject(EXAMPLE_LOG_BINDINGS.LOG_ACTION) protected logger: LogFn,
      ) {
        super(ctx, findRoute, parseParams, invoke, send, reject);
      }

      // Handle your request routing here:
      async handle(req: ParsedRequest, res: ServerResponse) {
        let args: any = [];
        let result: any;

        try {
          const route = this.findRoute(req);
          args = await this.parseParams(req, route);
          result = await this.invoke(route, args);
          await this.send(res, result);
        } catch (err) {
          this.reject(res, req, err);
          result = err;
        }

        await this.logger(req, args, result);
      }
    }

    server.sequence(MySequence);

[raymondfeng]

I'm adding support for that in #775.

[shimks]

@raymondfeng I've made a commit with @virkt25 's suggestion in mind, but should I revert it if you're adding in support for inheritance in @inject?

[shimks]

@slnode test please