Skip to content

Conversation

@mschnee
Copy link
Contributor

@mschnee mschnee commented Oct 20, 2021

Signed-off-by: Matthew Schnee matthew.schnee@bambee.com

This PR updates the options for GraphQLServer to supply the optional emitSchemaFile option. This is the same configuration used by TypeGraphQL's buildSchema method.

Note that this is the basic, naïve implementation that TypeGraphQL itself uses. For a full schema including support for custom directives, using GraphQLServer.exportGraphqlSpec may be preferable.

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

Signed-off-by: Matthew Schnee <matthew.schnee@bambee.com>
@mschnee mschnee requested a review from raymondfeng as a code owner October 20, 2021 20:03
@coveralls
Copy link

coveralls commented Oct 20, 2021

Pull Request Test Coverage Report for Build 1365146989

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 76.318%

Totals Coverage Status
Change from base Build 1363589294: 0.3%
Covered Lines: 16877
Relevant Lines: 17732

💛 - Coveralls

@mrmodise
Copy link
Contributor

@mschnee I see we both worked on the same thing. Anyways, please update the README to inform users of this feature. Other than LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants