fix: honor telemetry consent changes in running processes - #17
Merged
Conversation
fitz2882
marked this pull request as ready for review
September 5, 2026 13:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running processes could continue collecting and sending funnel telemetry after the effective consent setting changed. Recheck consent on hook, enqueue, flush, and exit paths, discard queued events and accumulated session data when the mode changes, and preserve environment-variable precedence. Document that requests already in flight cannot be recalled.
Validation: 124 focused funnel/core/telemetry tests pass, including empty-queue session metadata after opt-out. Regression cases fail against their previous implementations. A fresh independent reviewer approved the final commit; all 11 CI jobs pass across Python 3.10–3.13, framework integrations, lint, security, and packaging. Tests use mocked senders with no real telemetry or model calls.