Store sent_at per channel instead of once per notification - plus a bunch of renames #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renamed NotificationFrequency -> BaseFrequency - Renamed EmailFrequency model to NotificationFrequency model, it shouldn't be tied to "email" (closes #15) - Renamed NotificationType.default_email_frequency -> NotificationType.default_frequency - Renamed NotificationType.set_email_frequency -> NotificationType.set_frequency - Renamed NotificationType.get_email_frequency -> NotificationType.get_frequency - Renamed NotificationType.reset_email_frequency_to_default -> NotificationType.reset_frequency_to_default - Store sent_at per channel instead of once per notification, stored in new NotificationChannel model (closes #16) Breaking changes: if you made custom channels, frequencies or notification types, than please check the renames above. For most users these renames won't be breaking changes.
* main: Improve email sending (#13) # Conflicts: # generic_notifications/channels.py # generic_notifications/digest.py # tests/test_channels.py
kevinrenskers
changed the title
kevinrenskers
force-pushed
the
feat/improve-channels-frequencies
branch
from
42e6288 to
d2e4df2
Compare
kevinrenskers
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Show correct usage of the .prefetch() method in the readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rather substantial refactor for DGN v2. The TL;DR is that the library now makes it a lot easier to have multiple channels that work with digests, like an SMS or Slack channel. And the sent_at status is now stored per channel instead of once per notification.
Improvements
sent_email_attracking with per-channel delivery status via a newNotificationChannelmodel (closes Storeemail_sent_atper channel #16)Breaking changes
Class renames
NotificationChannel->BaseChannelNotificationFrequency->BaseFrequencyModel changes
EmailFrequencymodel toNotificationFrequencymodelMethod renames
NotificationType.default_email_frequency->NotificationType.default_frequencyNotificationType.set_email_frequency->NotificationType.set_frequencyNotificationType.get_email_frequency->NotificationType.get_frequencyNotificationType.reset_email_frequency_to_default->NotificationType.reset_frequency_to_defaultCommand and function renames
send_digest_emailscommand tosend_notification_digestsAPI changes
get_notification_preferencesfunction now returnsnotification_frequencyinstead ofemail_frequencyprocessmethod moved from individual channel implementations to theBaseChannelclass