Skip to content

Fix passkey cancellation, concurrent challenges and native app association - #641

Merged
lopugit merged 3 commits into
developfrom
codex/passkey-reliability
Sep 5, 2026
Merged

Fix passkey cancellation, concurrent challenges and native app association#641
lopugit merged 3 commits into
developfrom
codex/passkey-reliability

Conversation

@lopugit

@lopugit lopugit commented Sep 5, 2026

Copy link
Copy Markdown
Owner

Passkey prompts could compete with autofill, overwrite another tab鈥檚 challenge, or leave the UI waiting indefinitely when 1Password ignored cancellation. This gives each ceremony ownership and cancellation across options/browser/verification, restores cancelled or timed-out UI, isolates signed origin-bound challenges, and atomically rejects saved-cookie replay.

It also isolates settings caches by account, improves errors and mobile layout, and adds the missing iOS webcredentials entitlement plus Apple association routing. Passkey contracts are versioned in both manifests and checked by the client.

Validation: 54 live API checks with a software P-256 authenticator, 13 focused unit tests, 10 manifest tests, all 445 documentation endpoint checks, production Vite/Nitro build and built-handler smoke, Chrome/1Password cancellation and desktop/mobile settings checks, and an iOS Simulator build. Full TypeScript still reports 109 repository errors; none name changed passkey code.

Rollout: the public Apple application identifier is configured in Vercel for production/preview/custom develop, and a signed iOS Release IPA passes signature and entitlement checks. Production code deployment, native distribution, and physical-device biometric/provider acceptance remain required. Apple Developer permissions were not changed. Graphify outputs are refreshed; two semantic chunks exceeded the proxy request-size limit, so semantic coverage is partial.

The first CI API run exposed missing routing for Apple association documentation; GET/POST now pass locally and in the built server. Chrome also verified Cancel on the deployed HTTPS preview. Final Web CI (build, typecheck ratchet, unit tests and API suite) passed for 39fbbe8. The preview at 39fbbe8 was verified. A fresh preview is rebuilding to include the Apple association environment setting.

Preview: https://pr-641.previews.dev.thingtime.com

Detailed validation and deployment steps: PRs/641-passkey-reliability-fix-passkey-cancellation-concurrent-challenges-and-native-app-association.md.

@lopugit

lopugit commented Sep 5, 2026

Copy link
Copy Markdown
Owner Author

鈴笍 Develop S3 preview skipped

This PR or triggering actor is not currently eligible for the credentialed develop preview.

The ordinary generated Vercel Preview remains available on the shared development runtime.

@lopugit
lopugit temporarily deployed to develop-pr-641 September 5, 2026 08:19 Destroyed
@lopugit lopugit added the preview: develop building tt-preview-state:v1:develop:building label Sep 5, 2026
@lopugit
lopugit temporarily deployed to develop-pr-641 September 5, 2026 08:24 Destroyed
@lopugit lopugit added last preview built 05/09 18:48 AEST #641 tt-pv1:641:develop:199c6b767f43245a3445cbf6632490143e8e8f01:1788598128742 preview: develop ready tt-preview-state:v1:develop:ready preview: develop building tt-preview-state:v1:develop:building and removed preview: develop building tt-preview-state:v1:develop:building preview: develop ready tt-preview-state:v1:develop:ready labels Sep 5, 2026
@lopugit
lopugit temporarily deployed to develop-pr-641 September 5, 2026 08:26 Destroyed
@lopugit lopugit added preview: develop ready tt-preview-state:v1:develop:ready preview: develop building tt-preview-state:v1:develop:building and removed preview: develop building tt-preview-state:v1:develop:building preview: develop ready tt-preview-state:v1:develop:ready labels Sep 5, 2026
@lopugit
lopugit temporarily deployed to develop-pr-641 September 5, 2026 08:27 Destroyed
@lopugit lopugit added preview: develop ready tt-preview-state:v1:develop:ready and removed preview: develop building tt-preview-state:v1:develop:building labels Sep 5, 2026
@lopugit lopugit added preview: develop building tt-preview-state:v1:develop:building and removed preview: develop ready tt-preview-state:v1:develop:ready labels Sep 5, 2026
@lopugit
lopugit temporarily deployed to develop-pr-641 September 5, 2026 08:48 Destroyed
@lopugit lopugit added preview: develop ready tt-preview-state:v1:develop:ready and removed preview: develop building tt-preview-state:v1:develop:building labels Sep 5, 2026
@lopugit
lopugit merged commit bc061f6 into develop Sep 5, 2026
117 checks passed
@lopugit lopugit added preview: develop removed tt-preview-state:v1:develop:removed and removed preview: develop ready tt-preview-state:v1:develop:ready labels Sep 5, 2026
@lopugit

lopugit commented Sep 5, 2026

Copy link
Copy Markdown
Owner Author

馃 Promotion conflict resolution was queued automatically for promote/pr-641-passkey-reliability--to-main at exact base main (5e20cdca5510fe6d33096cfe3723b666302a5cee).

Conflicted source paths: README.md, remix/app/api/utils/capabilities/thingtimeCapabilities.test.ts.

The trusted worker will reconstruct, verify, publish, and attest the review branch; no manual branch update is needed.

@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

鈿狅笍 Lopu did not complete the promotion resolution before a reviewable PR was fully published.

Branch: promote/pr-641-passkey-reliability--to-main 路 base: main at e30df5dd506ff3fc1a04b31e90c5aa4e03a488d0 路 plan: ba247184913d84b9c4fc34b6558d6059088f0eb437345c7839cd0b305db6305e.

No newer branch work was overwritten or deleted. The same immutable snapshot will not spend AI again; a changed source/base snapshot retries automatically. Review the run.

@lopugit

lopugit commented Sep 5, 2026

Copy link
Copy Markdown
Owner Author

馃 Promotion conflict resolution was queued automatically for promote/pr-641-passkey-reliability--to-main at exact base main (65b03ace91a3002962c92cb908be291a0d909c24).

Conflicted source paths: README.md, remix/CHANGELOG.md, remix/app/api/utils/capabilities/thingtimeCapabilities.test.ts.

The trusted worker will reconstruct, verify, publish, and attest the review branch; no manual branch update is needed.

@lopugit

lopugit commented Sep 5, 2026

Copy link
Copy Markdown
Owner Author

馃 Promotion conflict resolution was queued automatically for promote/pr-641-passkey-reliability--to-main at exact base main (e30df5dd506ff3fc1a04b31e90c5aa4e03a488d0).

Conflicted source paths: README.md, remix/CHANGELOG.md, remix/app/api/utils/capabilities/thingtimeCapabilities.test.ts, remix/app/hooks/useApi.tsx, remix/package.json.

The trusted worker will reconstruct, verify, publish, and attest the review branch; no manual branch update is needed.

@github-actions github-actions Bot added the ai-promotion-paused Automatic promotion resolution paused for this exact snapshot label Sep 5, 2026
@lopugit

lopugit commented Sep 5, 2026

Copy link
Copy Markdown
Owner Author

馃 Promotion conflict resolution was queued automatically for promote/pr-641-passkey-reliability--to-main at exact base main (e30df5dd506ff3fc1a04b31e90c5aa4e03a488d0).

Conflicted source paths: README.md, remix/CHANGELOG.md, remix/app/api/utils/capabilities/thingtimeCapabilities.test.ts, remix/app/hooks/useApi.tsx, remix/package.json.

The trusted worker will reconstruct, verify, publish, and attest the review branch; no manual branch update is needed.

鈿狅笍 Source lineage is review-required-ambiguous; the resulting PR will carry source-lineage-unverified and must be reviewed for restoration intent.

@github-actions github-actions Bot added ai-promotion-paused Automatic promotion resolution paused for this exact snapshot and removed ai-promotion-paused Automatic promotion resolution paused for this exact snapshot labels Sep 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-promotion-paused Automatic promotion resolution paused for this exact snapshot last preview built 05/09 18:48 AEST #641 tt-pv1:641:develop:199c6b767f43245a3445cbf6632490143e8e8f01:1788598128742 preview: develop removed tt-preview-state:v1:develop:removed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant