fix(updater): don't treat brew outdated's exit code as failure - #22
Merged
Conversation
brew outdated <formula> --json=v2 intentionally exits non-zero when the named formula is outdated (Homebrew.failed = args.named.present? && outdated.present?). This is brew's convention for scripting, not an execution failure, but the updater was bailing out early on any non-success status without ever inspecting stdout - so a real update notification was being reported as "brew update failed" instead. Extract handle_brew_outdated_output() which now inspects stdout instead of the process exit status: only an empty stdout is treated as a real failure, matching brew's actual failure mode (no output at all).
Owner
Author
|
Closes #19 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew outdated --json=v2 intentionally exits non-zero when the named formula is outdated (Homebrew.failed = args.named.present? && outdated.present?). This is brew's convention for scripting, not an execution failure, but the updater was bailing out early on any non-success status without ever inspecting stdout - so a real update notification was being reported as "brew update failed" instead.
Extract handle_brew_outdated_output() which now inspects stdout instead of the process exit status: only an empty stdout is treated as a real failure, matching brew's actual failure mode (no output at all).