Skip to content

Fix npm publish auth failure in sdk-publish workflow - #35

Merged
loreste merged 1 commit into
mainfrom
fix/sdk-publish-auth
Aug 8, 2026
Merged

Fix npm publish auth failure in sdk-publish workflow#35
loreste merged 1 commit into
mainfrom
fix/sdk-publish-auth

Conversation

@loreste

@loreste loreste commented Aug 8, 2026

Copy link
Copy Markdown
Owner

Summary

  • The sdk-publish workflow was explicitly unsetting NODE_AUTH_TOKEN and deleting the registry auth token after upgrading npm globally, which destroyed credentials configured by actions/setup-node
  • Removed the npm global upgrade and token deletion lines, and set NODE_AUTH_TOKEN via the step's env block instead

Test plan

  • Verify CI passes on this PR
  • Next tag push triggers a successful npm publish

Summary by CodeRabbit

  • Chores
    • Improved the package publishing workflow to use authentication more reliably.
    • Removed unnecessary package manager upgrades and token cleanup steps during publishing.

The workflow was unsetting NODE_AUTH_TOKEN and deleting the registry
auth token after upgrading npm globally, which destroyed the credentials
configured by actions/setup-node. Remove the npm upgrade and explicit
token deletion, and pass NODE_AUTH_TOKEN via env block instead.
@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 37ca8f42-4d76-44d0-b27d-9ae42d49972f

📥 Commits

Reviewing files that changed from the base of the PR and between ff65cae and 786aeb6.

📒 Files selected for processing (1)
  • .github/workflows/sdk-publish.yml

📝 Walkthrough

Walkthrough

The SDK publish workflow now passes NPM_TOKEN through NODE_AUTH_TOKEN. It also removes the npm upgrade and registry-token cleanup commands.

Changes

SDK publish workflow

Layer / File(s) Summary
Configure SDK publish authentication
.github/workflows/sdk-publish.yml
The Node publish step sets NODE_AUTH_TOKEN from the NPM_TOKEN secret and removes the previous npm upgrade and token-clearing commands.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • loreste/loom#32: This PR also changes npm authentication handling in the SDK publish workflow.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the workflow change that fixes npm publish authentication failures.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/sdk-publish-auth

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@loreste
loreste merged commit 988e95c into main Aug 8, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant