Prevent Windows debug stack overflows#11
Conversation
|
@coderabbitai[bot] review |
📝 WalkthroughWalkthroughThe type checker is refactored into dedicated expression and builtin-call helpers. Development profile settings, a deep expression-stack example, Windows CI coverage, and an unreleased changelog entry are added. ChangesType-checking and stack validation
Estimated code review effort: 4 (Complex) | ~45 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Action performedReview finished.
|
Splits the large recursive type-checking and code-generation dispatchers into bounded handlers, preventing stack overflows on Windows debug builds without changing behavior.
Adds a regression covering 32 nested builtin calls and a 20-call method chain. The previous debug compiler overflows on this fixture; the refactored compiler passes it. Comments preserve the reason for the deliberately split dispatch structure.
Verified with
cargo test --bin mako(78 passed) and the focused Mako regression test.Summary by CodeRabbit
Bug Fixes
Build Improvements
Tests