Skip to content

Make filesystem tests portable on Windows#15

Merged
loreste merged 1 commit into
loreste:mainfrom
attahn:fix/windows-portable-temp-paths
Jul 22, 2026
Merged

Make filesystem tests portable on Windows#15
loreste merged 1 commit into
loreste:mainfrom
attahn:fix/windows-portable-temp-paths

Conversation

@attahn

@attahn attahn commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Replaces hard-coded /tmp paths in the buffer, database, filesystem, environment, and plugin tests with portable temporary paths. The tests now clean up their files and run in the blocking Windows core suite.

This keeps Windows coverage from being skipped because test fixtures assumed a Unix filesystem layout.

Verified with the focused tests on Windows and WSL/Clang, plus 78 Rust tests.

@attahn

attahn commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

@coderabbitai[bot] review

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

@attahn: I’ll review the changes, with particular attention to cross-platform temporary-path handling and fixture cleanup.

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@attahn, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 17 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8c250ac3-188e-40d6-ba1a-37154c7ab0d2

📥 Commits

Reviewing files that changed from the base of the PR and between ba73948 and 1cc62b1.

📒 Files selected for processing (7)
  • .github/workflows/ci.yml
  • CHANGELOG.md
  • examples/db_engine/lib.mko
  • examples/testing/bufio_test.mko
  • examples/testing/file_env_test.mko
  • examples/testing/fs_polish_test.mko
  • examples/testing/plugin_product_test.mko
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@attahn

attahn commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

The Windows failure is the existing task-result regression on upstream main: crew_fan_test.mko receives zero from completed tasks. PR #14 restores the Windows join behavior and covers this failure. The filesystem portability tests in this PR pass; I will update this branch after #14 lands so CI can rerun against the corrected baseline.

@loreste
loreste merged commit 6db5917 into loreste:main Jul 22, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants