Make filesystem tests portable on Windows#15
Conversation
|
@coderabbitai[bot] review |
|
✅ Action performedReview finished.
|
|
Warning Review limit reached
Next review available in: 17 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The Windows failure is the existing task-result regression on upstream main: crew_fan_test.mko receives zero from completed tasks. PR #14 restores the Windows join behavior and covers this failure. The filesystem portability tests in this PR pass; I will update this branch after #14 lands so CI can rerun against the corrected baseline. |
Replaces hard-coded
/tmppaths in the buffer, database, filesystem, environment, and plugin tests with portable temporary paths. The tests now clean up their files and run in the blocking Windows core suite.This keeps Windows coverage from being skipped because test fixtures assumed a Unix filesystem layout.
Verified with the focused tests on Windows and WSL/Clang, plus 78 Rust tests.