Skip to content

Fix cross-platform CI failures#6

Merged
loreste merged 4 commits into
loreste:mainfrom
attahn:fix/ci-failures
Jul 19, 2026
Merged

Fix cross-platform CI failures#6
loreste merged 4 commits into
loreste:mainfrom
attahn:fix/ci-failures

Conversation

@attahn

@attahn attahn commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Fixes the current cross-compilation and sanitizer failures.

  • make Windows and WASI runtime shims portable
  • remove UBSan-reported undefined behavior
  • fix plugin compilation and flaky blocking tests
  • restore the claims-gate dependency and scope ASan to invalid memory access

Tests: cargo test passed, sanitizer checks passed, and all cross artifacts validated.

@coderabbitai review

Summary by CodeRabbit

  • Bug Fixes

    • Improved zigzag integer encoding robustness and refined JPEG DCT DC evidence extraction.
    • Updated hot-reload stamp computation.
    • Improved string equality and adjusted WASI file/path behaviors; enhanced Windows time handling compatibility.
  • Tests

    • Strengthened JPEG DCT DC assertions.
    • Made IPv6 TCP/UDP loopback tests more reliable with consistent timeouts and non-blocking accepts.
    • Simplified hot-reload swap assertion for clearer verification.
  • Chores / CI

    • Added mandatory ripgrep availability checks and updated sanitizer run configuration (leak detection disabled).

@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4067cf70-04dc-4e85-887c-b8fc644105bf

📥 Commits

Reviewing files that changed from the base of the PR and between c6bf09a and 370728f.

📒 Files selected for processing (1)
  • examples/testing/net_ipv6_he_test.mko
🚧 Files skipped from review as they are similar to previous changes (1)
  • examples/testing/net_ipv6_he_test.mko

📝 Walkthrough

Walkthrough

Runtime portability and WASI behavior are updated, integer and JPEG encoding paths are made width-safe, hot-reload hashing and string comparison change, and networking tests and CI settings are adjusted.

Changes

Runtime and validation updates

Layer / File(s) Summary
Platform and WASI compatibility
runtime/mako_platform.h, runtime/mako_plugin.h, runtime/mako_rt.h
Windows time shims use Mako-prefixed functions with macro aliases; plugin headers rely on mako_rt.h; WASI filesystem operations receive compatibility branches.
Runtime data and hashing behavior
runtime/mako_domain.h, runtime/mako_goext.h, runtime/mako_rt.h, runtime/mako_std.h
String comparison, hot-reload stamp mixing, zigzag encoding, and JPEG DCT value reconstruction are updated.
Networking test control flow
examples/testing/net_ipv6_he_test.mko
IPv6 TCP and UDP tests use 5000ms timeouts, readiness waits, and non-blocking accept handling.
Test and CI execution updates
examples/testing/goext_wave5_test.mko, examples/testing/residual_seeds_test.mko, .github/workflows/ci.yml, scripts/claims-gate.sh
Tests assert updated JPEG and hot-reload behavior; claims-gate requires ripgrep; and ASan leak detection is disabled for the suite.

Estimated code review effort: 3 (Moderate) | ~20 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main theme of the changes: fixing cross-platform CI and portability failures.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@attahn

attahn commented Jul 19, 2026

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@attahn
attahn marked this pull request as ready for review July 19, 2026 08:39
@attahn attahn mentioned this pull request Jul 19, 2026
@loreste
loreste merged commit 86a5c2e into loreste:main Jul 19, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants