#800 correct handling parameter value empty array

[senid231]

Description

correct handling of parameters when value is an empty array
fix #800

Todos

List any remaining work that needs to be done, i.e:

• Tests
• Documentation (not sure where it should be documented)

Additional Notes

Optional section
will fix JsonApiClient/json_api_client#278

[olleolleolle]

Perhaps the Array#empty? method is even clearer to read? For both the !value.empty? and for the value.empty? case.

[iMacTia]

I'd go a step further and merge this 2 branches:

...
elsif value.is_a?(Array)
  return "#{parent}%5B%5D" if value.empty? # This is the only new line
  buffer = ""
  value.each_with_index do |val, i|
    new_parent = "#{parent}%5B%5D"
     buffer << "#{to_query.call(new_parent, val)}&"
  end
  return buffer.chop
...

[senid231]

nice catch
fixed

[olleolleolle]

Cool change, thanks for the contextual link to the other issue.

[iMacTia]

I'd go a step further and merge this 2 branches:

...
elsif value.is_a?(Array)
  return "#{parent}%5B%5D" if value.empty? # This is the only new line
  buffer = ""
  value.each_with_index do |val, i|
    new_parent = "#{parent}%5B%5D"
     buffer << "#{to_query.call(new_parent, val)}&"
  end
  return buffer.chop
...

[iMacTia]

Nice optimisation, looks good now.