fix: resolve breaking changes from geo 0.32 and rusty-leveldb 4 bumps#783
Merged
fix: resolve breaking changes from geo 0.32 and rusty-leveldb 4 bumps#783
Conversation
Owner
louis-e
commented
Mar 14, 2026
louis-e
commented
- geo 0.32.0 removed the concavity argument from concave_hull(); migrate to concave_hull_with_options(ConcaveHullOptions { concavity, ..Default::default() })
- rusty-leveldb 4.x is incompatible with bedrockrs_level which requires 3.x; revert direct dependency back to version 3
- geo 0.32.0 removed the concavity argument from concave_hull(); migrate to
concave_hull_with_options(ConcaveHullOptions { concavity, ..Default::default() })
- rusty-leveldb 4.x is incompatible with bedrockrs_level which requires 3.x;
revert direct dependency back to version 3
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the codebase to compile cleanly after upstream dependency changes in geo (0.32.x API change) and resolves a Bedrock feature dependency incompatibility by aligning rusty-leveldb back to the 3.x series.
Changes:
- Migrate
MultiPoint::concave_hull()usage toconcave_hull_with_options(ConcaveHullOptions { ... })forgeo0.32.0 compatibility. - Revert
rusty-leveldbdirect dependency from 4.x to 3.x to matchbedrockrs_levelexpectations. - Refresh
Cargo.lockto remove therusty-leveldb4.x tree and associated dependencies.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/urban_ground.rs |
Updates concave hull callsite to the new geo 0.32 options-based API. |
Cargo.toml |
Pins optional rusty-leveldb back to major version 3 for Bedrock compatibility. |
Cargo.lock |
Reflects dependency graph changes (removes rusty-leveldb 4.x + crc32c). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
⏱️ Benchmark run finished in 0m 25s 📈 Compared against baseline: 30s 📅 Last benchmark: 2026-03-14 17:17:39 UTC You can retrigger the benchmark by commenting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.