Add GOV Notify integration for notifications #5660
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced GOV Notify as a new notification provider, enabling support for email and SMS notifications via the GOV.UK Notify API. Updated relevant components, configuration, and dependencies to support this integration. This includes a dedicated form for GOV Notify in the notification dialog and backend logic for message handling. Signed-off-by: Toby Liddicoat <toby@codesure.co.uk>
Introduced a toggle in the UI to securely display or edit the GOV Notify API key. Updated the backend to include dynamic subject lines and timestamps in notifications to improve clarity and contextual information for recipients. Signed-off-by: Toby Liddicoat <toby@codesure.co.uk>
Reformatted code across multiple modules, standardizing string quotes, indentation, and spacing. Improved readability by restructuring blocks and aligning object properties consistently. These changes ensure better code maintainability and follow standard conventions. Signed-off-by: Toby Liddicoat <toby@codesure.co.uk>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| var md4sum = crypto.createHash('md4'); | ||
| md4sum.update(new Buffer.from(password, 'ucs2')); | ||
| var md4sum = crypto.createHash("md4"); | ||
| md4sum.update(new Buffer.from(password, "ucs2")); |
Check failure
Code scanning / CodeQL
Use of password hash with insufficient computational effort High
| var hmac = crypto.createHmac('md5', ntlmhash); | ||
| hmac.update(new Buffer.from(username.toUpperCase() + authTargetName, 'ucs2')); | ||
| var hmac = crypto.createHmac("md5", ntlmhash); | ||
| hmac.update(new Buffer.from(username.toUpperCase() + authTargetName, "ucs2")); |
Check failure
Code scanning / CodeQL
Use of a broken or weak cryptographic algorithm High
Standardize spacing for array brackets across the codebase to improve readability and consistency. Additionally, relocate the eslint-disable comment for clarity and ensure proper association with the unused variable declaration. Signed-off-by: Toby Liddicoat <toby@codesure.co.uk>
Corrected spacing in function parameters and object definitions across multiple files to improve code readability and maintain consistency. No functionality was altered as part of these changes. Signed-off-by: Toby Liddicoat <toby@codesure.co.uk>
CommanderStorm
requested changes
Mar 7, 2025
Collaborator
There was a problem hiding this comment.
The PR is not currently in a reviewable state:
- Please look over all changes if you intended to make them or not. You are currently changing 800 lines (most of them unintentionally) which is not reviewable
- you are currently failing CI
- Please make sure to include the screenshots, that we ask for in https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
CommanderStorm
added
the
pr:please address review comments
Collaborator
I am going to close this due to the above reasons. |
CommanderStorm
removed
pr:please address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced GOV Notify as a new notification provider, enabling support for email and SMS notifications via the GOV.UK Notify API. Updated relevant components, configuration, and dependencies to support this integration. This includes a dedicated form for GOV Notify in the notification dialog and backend logic for message handling.
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Fixes #(issue)
Type of change
Please delete any options that are not relevant.
Checklist
Screenshots (if any)
Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.