fix: move initial async status printer update#176
Merged
AlexJones0 merged 1 commit intolowRISC:masterfrom Apr 7, 2026
Merged
Conversation
Under heavy load, if DVSim is doing a lot of stuff and does not yield to the status printer's async run task, the initial print time can be off by a couple second from `00:00:00`. This doesn't really matter but hurts the UX a bit, when the intention is that the displayed time should be locked at `00:00:00` for targets that have not yet started execution, up until the first job in that target changes status. Signed-off-by: Alex Jones <alex.jones@lowrisc.org>
AlexJones0
force-pushed
the
async_status_printer_nit
branch
from
bacc83d to
9031ef4
Compare
Contributor
Author
|
Last force push was just a rebase after #172 was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A very minor nit/fix to make the UX of the new async status printer slightly nicer.
Under heavy load, if DVSim is doing a lot of stuff and does not yield to the status printer's async run task, the initial print time can be delayed by a couple of seconds from
00:00:00. This doesn't really matter but it isn't the intended behaviour, which is that the displayed time should be locked at00:00:00for targets that have not yet started execution, up until the first job in that target changes status.