[rom_ext] Refactor signature verificaion functions #26558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Consolidate public key data into `owner_keydata_t`. 2. Eliminate RSA as a supported algorithm. Signed-off-by: Chris Frantz <cfrantz@google.com>
Refactor the ROM_EXT signature verification functions into a verify function that can be used both for validating application payloads and ownership operations. Signed-off-by: Chris Frantz <cfrantz@google.com>
This target is a left-over from pre-ownership RSA verification and is no longer needed. Signed-off-by: Chris Frantz <cfrantz@google.com>
moidx
approved these changes
Mar 11, 2025
| // A version of spx_verify that is tailored to ROM_EXT use cases. | ||
| // In particular: | ||
| // - We don't care about the OTP setting for SPX+ in the ROM_EXT. | ||
| // - We don't care about flash_exec in the ROM_EXT. |
Contributor
There was a problem hiding this comment.
As discussed offline, lets think about adding a magic constant so that we can add redundant checks. This can be done in a follow up PR.
Contributor
Author
There was a problem hiding this comment.
I'd like to take care of the magic constant for redundancy in a stand-alone PR so that it can be reviewed in isolation (without a bunch of other code moving and refactoring).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the ROM_EXT signature verification functions into a verify
function that can be used both for validating application payloads and
ownership operations.