[rescue] Do not automatically reboot #26728
Conversation
cfrantz
requested review from
jon-flatley
and removed request for
a team and
jon-flatley
cfrantz
force-pushed
the
rescue-no-reboot
branch
from
eb76230 to
f52a739
Compare
| self.uart.set_break(true)?; | ||
| } | ||
| EntryMode::None => { | ||
| self.uart.set_break(true)?; |
There was a problem hiding this comment.
Does the ROM_EXT print its banner again, (and reset to initial mode), if it detects break condition? That makes sense.
There was a problem hiding this comment.
Break, on its own, does not affect the rescue state. EntryMode::None is for test cases that may have some out-of-band mechanism of resetting the chip or triggering rescue mode.
We set break condition so that if the chip goes through reset, rescue will be triggered again.
|
I've also added a test to make sure opentitantool interacts correctly with rescue protocol version 0. The test case includes pre-compiled FPGA ROM_EXT binaries. We can remove the test case when we no longer care about supporting version 0. I expect that will be in about 3 to 6 months. |
cfrantz
force-pushed
the
rescue-no-reboot
branch
3 times, most recently
from
db8fdca to
3637d99
Compare
Rescue mode should not automatically reboot the chip after processing a data transfer. Instead, the chip should wait for a subsequent command or a reboot request via the `REBO` command. This mode of operation is more aligned with how alternate rescue protocols (like USB-DFU) work. Making this behavior consistent among the supported protocols allows for easier test automation and configuration flows. Addresses: lowRISC#26481 Signed-off-by: Chris Frantz <cfrantz@google.com>
cfrantz
force-pushed
the
rescue-no-reboot
branch
from
3637d99 to
760db7b
Compare
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin master
git worktree add -d .worktree/backport-26728-to-master origin/master
cd .worktree/backport-26728-to-master
git switch --create backport-26728-to-master
git cherry-pick -x 760db7b73efb7eed9a922147d187ecf72352b0d3 |
github-actions
bot
added
the
Manually CherryPick
3 participants
Rescue mode should not automatically reboot the chip after processing a data transfer. Instead, the chip should wait for a subsequent command or a reboot request via the
REBOcommand.This mode of operation is more aligned with how alternate rescue protocols (like USB-DFU) work. Making this behavior consistent among the supported protocols allows for easier test automation and configuration flows.
Addresses: #26481