Skip to content

ot_spi_device: Adjust SPI device definitions #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2025
Merged

ot_spi_device: Adjust SPI device definitions #244

merged 1 commit into from
Oct 23, 2025

Conversation

@pl-halfboy
Copy link

Regenerate SPI device definitions using ./scripts/opentitan/autoreg.py script and verify them by hand with System Verilog code from OpenTitan repo.

@rivos-eblot rivos-eblot mentioned this pull request Oct 17, 2025
Merged
@rivos-eblot rivos-eblot changed the title hw/opentitan: ot_spi_device: Adjust SPI device definitions ot_spi_device: Adjust SPI device definitions Oct 17, 2025
AlexJones0
AlexJones0 reviewed Oct 22, 2025
View reviewed changes
Copy link

@AlexJones0 AlexJones0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks correct to me.

Can you also add an [ot] prefix to your commit message?

@pl-halfboy
Copy link
Author

Thanks, this looks correct to me.

Can you also add an [ot] prefix to your commit message?

Thanks. This is done, prefix added

AlexJones0
AlexJones0 approved these changes Oct 23, 2025
View reviewed changes
Copy link

@AlexJones0 AlexJones0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@AlexJones0
Copy link

If you rebase on the latest ot-9.2.0 this should fix the CI errors, although GitHub seems to be a bit flaky at the moment so there might be some failures anyway 😅

@pl-halfboy
[ot] hw/opentitan: ot_spi_device: Adjust SPI device definitions
5952100 
Regenerate SPI device definitions using ./scripts/opentitan/autoreg.py
script and verify them by hand with System Verilog code from OpenTitan
repo.

Signed-off-by: Mateusz Półchłopek <mateusz@plasteli.net>
@pl-halfboy
Copy link
Author

If you rebase on the latest ot-9.2.0 this should fix the CI errors, although GitHub seems to be a bit flaky at the moment so there might be some failures anyway 😅

yes, after rebase it works, thanks 😄

@AlexJones0 AlexJones0 merged commit b03205a into lowRISC:ot-9.2.0 Oct 23, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexJones0 AlexJones0 AlexJones0 approved these changes

@jwnrt jwnrt Awaiting requested review from jwnrt

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pl-halfboy @AlexJones0