-
Notifications
You must be signed in to change notification settings - Fork 31
Impement navigation menu for the LCD demo #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@marnovandermaas can you review the "Fix SPI driver" and "Fix timing freq parameter" commits? They're needed to make the existing LCD demo functional again |
@nbdd0121 Thanks for making these fixes! From reading them they look very reasonable to me. I would like to test the SPI flash test on FPGA before merging this PR so let me know when this is ready to be tested. |
|
@marnovandermaas the code is now ready. Could you test the flash? |
marnovandermaas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested the CHERI version of the SPI test which works well. I also tested your LCD demo and it works on my board as well.
I have mentioned a change to spi.h, but even with that change the SPI test is broken. That can be fixed in a subsequent PR though.
Co-authored-by: Marno van der Maas <mvdmaas+git@lowrisc.org>
Update code from upstream repository https://github.com/engdoreis/display_drivers.git to revision d0ea11852c43bd7db2ba9316e4170b8297a1d6a0 * Fix text rendering when font is not monospace (Gary Guo) * Add m3x6 font (Gary Guo) * Add font bitmap generation tool (Gary Guo) * Store the rgb colors on the st7735 layer (Douglas Reis) * Fix the orientation enum (Douglas Reis) * Fix warnings on restrictive compiler flags (Douglas Reis) Signed-off-by: Gary Guo <gary.guo@lowrisc.org>
I need a
snprintfimplementation so I take the implementation from OpenTitan runtime.