Skip to content

Conversation

@nbdd0121
Copy link
Contributor

@nbdd0121 nbdd0121 commented May 1, 2024

I need a snprintf implementation so I take the implementation from OpenTitan runtime.

@nbdd0121 nbdd0121 requested review from engdoreis and luismarques May 1, 2024 13:55
@nbdd0121 nbdd0121 marked this pull request as draft May 1, 2024 14:04
@nbdd0121 nbdd0121 requested a review from marnovandermaas May 1, 2024 14:51
@nbdd0121
Copy link
Contributor Author

nbdd0121 commented May 1, 2024

@marnovandermaas can you review the "Fix SPI driver" and "Fix timing freq parameter" commits? They're needed to make the existing LCD demo functional again

@marnovandermaas
Copy link
Contributor

@marnovandermaas can you review the "Fix SPI driver" and "Fix timing freq parameter" commits? They're needed to make the existing LCD demo functional again

@nbdd0121 Thanks for making these fixes! From reading them they look very reasonable to me. I would like to test the SPI flash test on FPGA before merging this PR so let me know when this is ready to be tested.

@nbdd0121 nbdd0121 marked this pull request as ready for review May 3, 2024 11:18
@nbdd0121
Copy link
Contributor Author

nbdd0121 commented May 3, 2024

@marnovandermaas the code is now ready. Could you test the flash?

Copy link
Contributor

@marnovandermaas marnovandermaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the CHERI version of the SPI test which works well. I also tested your LCD demo and it works on my board as well.

I have mentioned a change to spi.h, but even with that change the SPI test is broken. That can be fixed in a subsequent PR though.

nbdd0121 and others added 8 commits May 3, 2024 15:37
Co-authored-by: Marno van der Maas <mvdmaas+git@lowrisc.org>
Update code from upstream repository
https://github.com/engdoreis/display_drivers.git to revision
d0ea11852c43bd7db2ba9316e4170b8297a1d6a0

* Fix text rendering when font is not monospace (Gary Guo)
* Add m3x6 font (Gary Guo)
* Add font bitmap generation tool (Gary Guo)
* Store the rgb colors on the st7735 layer (Douglas Reis)
* Fix the orientation enum (Douglas Reis)
* Fix warnings on restrictive compiler flags (Douglas Reis)

Signed-off-by: Gary Guo <gary.guo@lowrisc.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants