ci: upgrade CI to SQL Server 2025 - #396
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
All reviewed CI updates are consistent, with no unresolved issues.
This review doesn't count toward merge requirements.
Pull request overview
Updates Linux and Windows CI to test against stable SQL Server 2025.
Changes:
- Uses the official SQL Server 2025 Linux container.
- Configures both Windows installation attempts for SQL Server 2025.
File summaries
| File | Description |
|---|---|
.github/workflows/ansible-test.yml |
Updates the Linux integration-test image. |
.github/workflows/ansible-test-windows.yml |
Updates primary and retry Windows installations. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps CI to SQL Server 2025 (latest stable).
ansible-test-windows.yml:version: 2025for both the primary and retrypotatoqualitee/mssqlsuitesteps. Already pinned tov1.12, the latest action release, so no action version bump needed.ansible-test.yml: Linux integration container image tomcr.microsoft.com/mssql/server:2025-latest.Also dropped the
Get Linux workspace pathstep entirely. It computed aGHWSenv var (a hand-translated/mnt/c/...path) so laterwsl-bashsteps couldpushdinto the right directory. Turns out that's unnecessary:wsl.exeauto-translates the invoking Windows cwd to its DrvFs-mounted equivalent, so aworking-directory:pointing at the Windows-style repo path (same as the existingSet integration test optionsstep already did) landswsl-bashsteps in the right place with no extra computation. Verified locally:cd <windows-path>; wsl bash -c pwdreturns the matching/mnt/c/...path directly.Testing
CI is the validity check here; no local SQL Server run.