Parse prefix assignment with a discarded rest#45
Merged
Conversation
A string-prefix concatenation pattern that binds the prefix with `as` and discards the rest, e.g. `"a" as letter <> _`, failed to parse with `UnexpectedToken(LessGreater, ...)`, even though the Gleam compiler accepts it. The `pattern` parser had arms for `"a" as x <> rest` (named rest) and `"a" <> _` (a discarded rest with no prefix assignment), but none combining a prefix assignment with a discarded rest. Add the missing `as Name <> Discarded` arm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A string-prefix concatenation pattern that binds the prefix with
asand discards the rest — e.g."a" as letter <> _— fails to parse withUnexpectedToken(LessGreater, ...), even though the Gleam compiler accepts it.patternalready handles"a" as x <> rest(named rest) and"a" <> _(a discarded rest with no prefix assignment), but had no arm combining a prefix assignment with a discarded rest. This adds the missingas Name <> Discardedarm.
Closes #44.