Add Leaderboard nav + linkout icons (current-tab) + sitemap fix#14
Merged
radinhamidi merged 1 commit intochore/copy-polishfrom Apr 30, 2026
Merged
Conversation
Three pieces of user-requested polish: 1. Marketing nav: add Leaderboard alongside Dashboard, both with the linkout arrow icon and opening in the current tab. Drop the trailing "↗" from the old "Dashboard ↗" label since the icon now conveys it. 2. Leaderboard nav: keep the Toolkit link (re-added earlier), with the same linkout icon, current-tab. 3. Header component: add a `newTab` prop separate from `external`. `external` controls icon rendering only; `newTab` controls target/rel. Default behavior is current-tab — let users middle-click / cmd-click for a new tab when they want one. Also propagate same-tab to EcosystemMap cards (they were forcing _blank for any http link). Sitemap visibility: `sitemap-index.xml` is one level above the URLs (it just points at sitemap-0.xml — standard Sitemaps protocol). When visited directly it looks empty. Updated <link rel="sitemap"> to point at /sitemap-0.xml so anything inspecting the page lands on the populated file. robots.txt now lists both URLs (crawlers handle either form). Stacked on chore/copy-polish (PR #13). Once that merges, this PR's diff narrows to just these files. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
radinhamidi
force-pushed
the
chore/nav-and-sitemap-stacked
branch
from
6e6ed64 to
fa6953f
Compare
This was referenced Apr 30, 2026
radinhamidi
added a commit
that referenced
this pull request
Apr 30, 2026
User feedback: Dashboard and Leaderboard links should open in the current tab, not a new one. The nav links were already clean (PR #14 work in this stack), but two more stragglers were forcing _blank: - Footer (Dashboard, GitHub, Docs, Paper) — flat link strip with target=_blank on every entry. Removed. - Leaderboard EmptyState's "How to submit a result →" CTA pointing at the contributor guide on RTD. Removed _blank for consistency with the rest of the leaderboard's links. Remaining target=_blank instances (intentionally kept) are on external research references: arXiv paper links on /methods, /cite, and /about; GitHub source-file links on /about and /reproducibility; RTD docs link on /install. These are research-citation conventions where readers expect parallel-tab reading. Happy to flip globally if that's the actual preference — just say. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three user-requested polish items.
1. Marketing nav: add Leaderboard alongside Dashboard
Both render an external-link icon and open in the current tab (not a new tab). Users can middle-click / cmd-click for a new tab when they want one — silently opening tabs is a worse default.
2. Leaderboard nav: Toolkit gets the linkout icon, current-tab
Same treatment for the cross-link to `querygym.com`.
3. Sitemap visibility
`sitemap-index.xml` is the standard top-level entry per Sitemaps protocol — it only points at `sitemap-0.xml`, where the actual URLs live. Visiting the index in a browser looks empty.
Updated:
Header component change
Added a `newTab` prop separate from `external`:
These are independent because most cross-site links should show "I lead off-site" without forcing a new tab.
Stacked on #13
Base is `chore/copy-polish` (PR #13). Once that merges this PR's diff narrows to the five files actually changed here.
Test plan
🤖 Generated with Claude Code