Recover orphaned PRs #14 + #15 (nav links + leaderboard sitemap)#16
Merged
radinhamidi merged 3 commits intomainfrom Apr 30, 2026
Merged
Recover orphaned PRs #14 + #15 (nav links + leaderboard sitemap)#16radinhamidi merged 3 commits intomainfrom
radinhamidi merged 3 commits intomainfrom
Conversation
Three pieces of user-requested polish: 1. Marketing nav: add Leaderboard alongside Dashboard, both with the linkout arrow icon and opening in the current tab. Drop the trailing "↗" from the old "Dashboard ↗" label since the icon now conveys it. 2. Leaderboard nav: keep the Toolkit link (re-added earlier), with the same linkout icon, current-tab. 3. Header component: add a `newTab` prop separate from `external`. `external` controls icon rendering only; `newTab` controls target/rel. Default behavior is current-tab — let users middle-click / cmd-click for a new tab when they want one. Also propagate same-tab to EcosystemMap cards (they were forcing _blank for any http link). Sitemap visibility: `sitemap-index.xml` is one level above the URLs (it just points at sitemap-0.xml — standard Sitemaps protocol). When visited directly it looks empty. Updated <link rel="sitemap"> to point at /sitemap-0.xml so anything inspecting the page lands on the populated file. robots.txt now lists both URLs (crawlers handle either form). Stacked on chore/copy-polish (PR #13). Once that merges, this PR's diff narrows to just these files. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Mirror what querygym.com already has: - @astrojs/sitemap integration. Home priority 1.0, per-dataset/method/ model index pages 0.5, run-detail pages 0.3 monthly (they're mostly internal-link targets so search engines should focus on the index pages). - robots.txt with the standard "Allow all + sitemap pointer" shape. - <link rel="sitemap"> in the layout for browser discoverability. Generates 37 URLs (1 home + 32 per-dataset + datasets/methods/models indexes + about) on the current empty-results state. The shard count will grow as runs land via submit_run.py. Stacked on chore/nav-and-sitemap-stacked (PR #14). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
User feedback: Dashboard and Leaderboard links should open in the current tab, not a new one. The nav links were already clean (PR #14 work in this stack), but two more stragglers were forcing _blank: - Footer (Dashboard, GitHub, Docs, Paper) — flat link strip with target=_blank on every entry. Removed. - Leaderboard EmptyState's "How to submit a result →" CTA pointing at the contributor guide on RTD. Removed _blank for consistency with the rest of the leaderboard's links. Remaining target=_blank instances (intentionally kept) are on external research references: arXiv paper links on /methods, /cite, and /about; GitHub source-file links on /about and /reproducibility; RTD docs link on /install. These are research-citation conventions where readers expect parallel-tab reading. Happy to flip globally if that's the actual preference — just say. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What happened
PRs #14 (`chore/nav-and-sitemap-stacked`) and #15 (`chore/leaderboard-sitemap`) were stacked on each other and on PR #13 (`chore/copy-polish`). When #13 merged into main, GitHub didn't auto-retarget the stacked PRs — it merged each into its now-deleted base branch instead. They show "MERGED" in GitHub's UI but none of their commits reached main, so:
This is the same merge-into-base bug that hit PR #12 earlier in the rollout. Lesson learned: stop stacking PRs in this repo. From here on, every PR bases off main.
Recovery
This PR cherry-picks the two orphaned commits onto a fresh branch off main:
Verified locally
After merge
🤖 Generated with Claude Code