fix: replace bare except clauses with except Exception in llmcore.py#556
Closed
Kailigithub wants to merge 1 commit into
Closed
fix: replace bare except clauses with except Exception in llmcore.py#556Kailigithub wants to merge 1 commit into
Kailigithub wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace 17 bare
except:clauses inllmcore.pywithexcept Exception:to follow Python best practices and pass ruff E722 lint checks.Changes
All bare
except:in llmcore.py replaced withexcept Exception::reload_mykeys()fallback_stream Anthropictool JSON parsing_try_parse_tool_args()JSON parsing fallback_parse_json_tool_calls_parse_text_tool_callsXML/JSON fallbacktryparse()multi-stage JSON parsingVerification
python3 -m py_compile llmcore.pypassesruff check llmcore.py --select E722reports all checks passed