fix(ci): checkout mdd as a sibling so the path dependency resolves - #1
Merged
Conversation
688406d switched pyproject.toml's uv source for `mdd` from a pinned git tag to a sibling-checkout path, but CI only ever checked out mdd-wrapper itself, so `uv sync` failed with "Distribution not found at: file:///.../mdd". Co-Authored-By: lsimons-bot <bot@leosimons.com> Assisted-by: Claude:claude-sonnet-5
actions/checkout rejects a path outside the workspace root
("Repository path '.../mdd' is not under '.../mdd-wrapper'"), so the
previous fix failed too. mdd is public and needs no auth, so a plain
git clone into the sibling directory works instead.
Co-Authored-By: lsimons-bot <bot@leosimons.com>
Assisted-by: Claude:claude-sonnet-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pyproject.toml's[tool.uv.sources]formddfrom a pinned git tag to a sibling-checkout path (../mdd), but the CI workflow only ever checked outmdd-wrapperitself.uv sync --all-groupsthen failed withDistribution not found at: file:///home/runner/work/mdd-wrapper/mdd, as seen in this failing run.schubergphilis/mddinto../mdd(relative to the workspace) beforemise run installso the path dependency resolves in CI the same way it does locally.Test plan
mise run installsucceeds against a sibling../mddcheckout, matching the layout the new CI step creates.mise run lint,mise run typecheck,mise run testall pass locally.Co-Authored-By: lsimons-bot bot@leosimons.com
Assisted-by: Claude:claude-sonnet-5