fix(web): use same-origin WS URL on default ports (HTTPS/443) - #2371
Merged
Conversation
getDaemonWsUrl() fell back to a hardcoded :8283 when window.location.port was empty. On HTTPS:443 (browsers omit default ports) behind a TLS-terminating proxy such as `tailscale serve --https 443`, the page loaded but the WS hit wss://<host>:8283/ws — a port nothing proxies — causing an instant "connection lost". Use same-origin (protocol default port) when no explicit port. Adds an optional `loc` param as a test seam. Regression test covers explicit-port, default-port (443), and http default-port cases.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
lsm has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
getDaemonWsUrl()hardcoded:8283whenwindow.location.portwas empty. On HTTPS:443 (browsers omit default ports) behind a TLS-terminating proxy such astailscale serve --https 443, the page loaded but the WS hitwss://<host>:8283/ws— a port nothing proxies → instant "connection lost".Fix
Use same-origin (protocol default port) when no explicit port. Optional
locparam added as a test seam.Verify
New
connection-manager-ws-url.test.ts— explicit port, 443 default-port regression, http default-port. 3/3 pass locally;tscandoxlintclean.