Require a pre-commit fixpoint before AFK commits#265
Merged
jonathansick merged 1 commit intomainfrom Apr 26, 2026
Merged
Conversation
Tighten afk-implement so the success condition is a single `pre-commit run --all-files` exiting 0 on a clean tree, not "exits 0 eventually after auto-fixes." Drive-by ruff fixes must be staged or reverted before commit, "X fixed, Y remaining" output is treated as a failure, and Phase 3 re-runs pre-commit as a push-time backstop that routes to stuck on any non-clean result. Closes the gap that let recent Ralph PRs land with red `lint` jobs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.claude/skills/afk-implement/SKILL.mdPhase 2 so the staging gate is an explicit fixpoint:pre-commit run --all-filesmust exit 0 andgit status --porcelainmust be empty in a single run before staging. Drive-by ruff auto-fixes on unrelated files must be staged or reverted, not left dangling.lintjob.pre-commit run --all-filesandgit status --porcelainbeforegit push; any non-clean result routes to the stuck path instead of pushing a tree CI will reject.Test plan
afk-implementSKILL.md and confirm the wording leaves no "exits 0 eventually" reading.gh pr checks <num> --repo lsst-sqre/docverseshould reportlintgreen.uv run --only-group=lint pre-commit run --all-filesonmainto confirm the baseline tree is clean (fixpoint semantics depend on it).