DM-53476: Set INEXACT_PSF mask bits in cell-coadds #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunkannawadi
force-pushed
the
tickets/DM-53476
branch
from
2417dbe to
6c92c5e
Compare
TallJimbo
approved these changes
Dec 4, 2025
| # The `if` branch is buggy. `dest_polygon` is technically | ||
| # out of scope, but Python does not raise an error. | ||
| # TODO: Fix this properly in DM-53479, but sweep it under | ||
| # the rug for now. |
Member
There was a problem hiding this comment.
Python's for scoping rules just don't work like those in other languages.
I'm guessing overlap_fraction < 0.5 basically assumes this never fires?
Member
Author
There was a problem hiding this comment.
That's exactly correct. And since overlap_fraction > 0.5 guarantees that a detector overlaps the center of the cell, the single-visit PSF can still be evaluated without extrapolating the model outside of the detector.
arunkannawadi
force-pushed
the
tickets/DM-53476
branch
from
6c92c5e to
e460b23
Compare
arunkannawadi
changed the title
arunkannawadi
force-pushed
the
tickets/DM-53476
branch
from
e460b23 to
38be31f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.