Skip to content

DM-53476: Set INEXACT_PSF mask bits in cell-coadds #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 4, 2025
Merged

DM-53476: Set INEXACT_PSF mask bits in cell-coadds #174

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c35237
Demote log level of skipped visits to DEBUG level
arunkannawadi Dec 4, 2025
9e9e548
Suppress the bug due to out-of-scope variable
arunkannawadi Dec 4, 2025
38be31f
Set iNEXACT_PSF mask bits
arunkannawadi Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions python/lsst/drp/tasks/assemble_cell_coadd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,6 +623,11 @@ def run(
)

removeMaskPlanes(warp.mask, self.config.remove_mask_planes, self.log)
# Instead of using self.config.bad_mask_planes, we explicitly
# ask statsCtrl which pixels are going to be ignored/rejected.
rejected = afwImage.Mask.getPlaneBitMask(
["CLIPPED", "REJECTED"] + afwImage.Mask.interpret(statsCtrl.getAndMask()).split(",")
)

# Compute the weight for each CCD in the warp from the visitSummary
# or from the warp itself, if not provided. Computing the weight
Expand Down Expand Up @@ -692,8 +697,7 @@ def run(
overlap_fraction = (detector_map[inner_bbox].array == ccd_row["ccd"]).mean()
assert -1e-4 < overlap_fraction < 1.0001, "Overlap fraction is not within [0, 1]."
if (overlap_fraction < self.config.min_overlap_fraction) or (overlap_fraction <= 0.0):
self.log.log(
self.log.DEBUG if overlap_fraction == 0.0 else self.log.INFO,
self.log.debug(
"Skipping %s in cell %s because it had only %.3f < %.3f fractional overlap.",
warp_input.dataId,
cellInfo.index,
Expand Down Expand Up @@ -751,7 +755,11 @@ def run(
psf_shape_flag = True
psf_eval_point = None
try:
if overlap_fraction < 1.0:
# The `if` branch is buggy. `dest_polygon` is technically
# out of scope, but Python does not raise an error.
# TODO: Fix this properly in DM-53479, but sweep it under
# the rug for now.
Copy link
Member

@TallJimbo TallJimbo Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python's for scoping rules just don't work like those in other languages.

I'm guessing overlap_fraction < 0.5 basically assumes this never fires?

Copy link
Member Author

@arunkannawadi arunkannawadi Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's exactly correct. And since overlap_fraction > 0.5 guarantees that a detector overlaps the center of the cell, the single-visit PSF can still be evaluated without extrapolating the model outside of the detector.

if overlap_fraction < 0.5:
psf_eval_point = dest_polygon.intersectionSingle(
geom.Box2D(inner_bbox)
).calculateCenter()
Expand Down Expand Up @@ -884,6 +892,11 @@ def run(
with np.errstate(invalid="ignore"):
varArray[:] = np.where(varArray > 0, varArray, np.inf)

afwImage.Mask.addMaskPlane("INEXACT_PSF")
cell_masked_image.mask.array[
(cell_masked_image.mask.array & rejected) > 0
] |= cell_masked_image.mask.getPlaneBitMask("INEXACT_PSF")

image_planes = OwnedImagePlanes.from_masked_image(
masked_image=cell_masked_image,
mask_fractions=cell_maskfrac_image,
Expand Down